Re: [PATCH 2/2] v4 x86/mrst: add more timer config options

From: jacob pan
Date: Tue May 18 2010 - 18:57:44 EST

>> +/**
> Do not use kerneldoc /** opener from plain comments. Randy
> complained about that yesterday already
I missed randy's comment at the end. sorry. I admit I did not know kernel-doc
before that.

if (mrst_identify_cpu() == MRST_CPU_CHIP_PENWELL) {
> Why do you want to pin that on PENWELL and not on ARAT ? If you
> check ARAT, you have coverd all next gen cpus as well.

I did try ARAT first but ARAT is not available at this point. the add-on cpu
features are set later.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at