Re: [Patch] 1/5 in support of hot-add memory x86_64 nodes_add cleanup

[Andi Kleen]

If you add attachments (which are harder to review because they cannot be 
quoted) put at least a copy of the description into the attachment and make
them inline.

One thing that's unclear to me is why you make the reserve hotadd Kconfig
user visible (and why put it into Kconfig at all). I don't think it should be 
user visible.

Also most of the patch seems to be renaming a variable which seems somewhat
pointless?

-Andi


On Saturday 29 July 2006 04:52, keith mannthey wrote:
>   This patch cleans up the srat.c file with respects to the 2 hot-add
> paths available.  It creates Kconfig options to represent the desired
> functionality and implements their usage.
>
>   The current code already saves the information need (NUMA locality of
> hot-add memory ranges) for MEMORY_HOTPLUG in the RESERVE_MEMORY path.  I
> amend the memory parsing code to support the needs of both and save the
> nodes_add data for use at runtime.
>
> Built against 2.6.18-rc2
>
> Signed-off-by:  Keith Mannthey <kmannth@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/