Re: [discuss] [Patch] 4/5 in support of hot-add memory x86_64 fix kernel mapping code

[Andi Kleen]

On Saturday 29 July 2006 04:52, keith mannthey wrote:
> Hello All,
>
>   phys_pud_init is broken when using it at runtime with some offsets.
> It currently only maps one pud entry worth of pages while trampling any
> mappings that may have existed on the pmd_page :(

To print x86-64 ptes you need a %016lx (or just %lx) 

it would be cleaner to recompute pmd inside the loop based on i
and use a standard for() 

It is unclear why you hardcode 0 as address in phys_pmd_update
when a real address is passed in?

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/