vxfs_readdir locking incorrect: add lock_kernel() or removeunlock_kernel()?

From: Josh Triplett
Date: Mon Jul 24 2006 - 18:40:11 EST

Commit 7b2fd697427e73c81d5fa659efd91bd07d303b0e in the historical GIT
tree stopped calling the readdir member of a file_operations struct with
the big kernel lock held, and fixed up all the readdir functions to do
their own locking. However, that change added calls to unlock_kernel()
in vxfs_readdir (fs/freevxfs/vxfs_lookup.c), but no call to
lock_kernel(). Should vxfs_readdir call lock_kernel(), or should the
calls to unlock_kernel() go away?

- Josh Triplett

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/