Re: vxfs_readdir locking incorrect: add lock_kernel() or removeunlock_kernel()?

[Andrew Morton]

On Mon, 24 Jul 2006 15:42:17 -0700
Josh Triplett <josht@xxxxxxxxxx> wrote:

> Commit 7b2fd697427e73c81d5fa659efd91bd07d303b0e in the historical GIT
> tree stopped calling the readdir member of a file_operations struct with
> the big kernel lock held, and fixed up all the readdir functions to do
> their own locking.  However, that change added calls to unlock_kernel()
> in vxfs_readdir (fs/freevxfs/vxfs_lookup.c), but no call to
> lock_kernel().

That would appear to imply that nobody has used freevxfs in four years.

>  Should vxfs_readdir call lock_kernel(), or should the
> calls to unlock_kernel() go away?

I don't see anything in there which needs the locking, apart from perhaps
f_pos updates.  But it's probably best to add the lock_kernel() - this is a
bugfixing exercise, not a remove-BKL-from-freevxfs exercise.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/