Re: [2.6 patch] kill drive_info

From: Andries Brouwer
Date: Thu Jul 15 2004 - 06:11:45 EST


On Thu, Jul 15, 2004 at 04:59:48AM +0200, Adrian Bunk wrote:
> On Wed, Jul 14, 2004 at 11:01:59AM +0200, Andries Brouwer wrote:
> >...
> > > - drive_info = DRIVE_INFO;
> >
> > Hmm. setup.c copies this info from where it was left after booting
> > to some safe place. You seem to think that this saving is not required.
> > Is it not?
>
> - boot_params is __initdata
> - hd_init in legacy/hd.c is __init
> - legacy/hd.c can't be built modular
>
> The situation is different in 2.4 where the new (possibly modular) IDE
> driver also uses drive_info .

Yes, I see that this area (which used to be empty_zero_page)
is independent since 2.6.5.

So, maybe your patch is correct.

[Still, the patch brings knowledge about boot_params that earlier was
concentrated in head.S, setup.c, setup.h to elsewhere in the kernel. Ach.]

The doc file is still called zero-page.txt. One might add

0x228 4 bytes command line buffer

and possibly rename it.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/