Re: [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function
From: Christoph Hellwig
Date: Fri May 16 2025 - 01:06:43 EST
On Fri, May 16, 2025 at 01:02:59PM +0800, Jason Xing wrote:
> Do you mean make it inline in include/linux/relay.h like how
> relay_write() works?
>
> Will do that.
Just drop the extern, which is not needed:
size_t relay_dump(struct rchan *chan, int flags);
> >
> > This export seems unused even with the entire series applied.
>
> My initial thought was to provide a symbol for some kernel modules to use.
The only user is blktrace, which can't be modular. Or you plan to
submit a modular user soon, like in the next merge window/ If so
note that and add a pointer to it in the cover letter.