Re: [PATCH V4] perf test: Allow tolerance for leader sampling test

[Thomas Richter]

On 5/15/25 17:53, Arnaldo Carvalho de Melo wrote:
> On Fri, May 02, 2025 at 04:11:55PM -0300, Arnaldo Carvalho de Melo wrote:
>> On Fri, May 02, 2025 at 11:21:07AM -0700, Chun-Tse Shao wrote:
>>> Hi Arnaldo,
>>>
>>> I submitted the patch v1 and Thomas helped me to modify and submit v2
>>> and v3 while I was OOO. In this case I am not sure which one should be
>>> the author, maybe just keep it as Thomas.
>>
>> >From the tags provided, I think it would be best to list you as the
>> author and Thomas a a Co-developer, like mentioned in:
>>
>> Documentation/process/submitting-patches.rst
>>
>> Co-developed-by: states that the patch was co-created by multiple developers;
>> it is used to give attribution to co-authors (in addition to the author
>> attributed by the From: tag) when several people work on a single patch.  Since
>> Co-developed-by: denotes authorship, every Co-developed-by: must be immediately
>> followed by a Signed-off-by: of the associated co-author.  Standard sign-off
>> procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the
>> chronological history of the patch insofar as possible, regardless of whether
>> the author is attributed via From: or Co-developed-by:.  Notably, the last
>> Signed-off-by: must always be that of the developer submitting the patch.
>>
>> Note, the From: tag is optional when the From: author is also the person (and
>> email) listed in the From: line of the email header.
>>
>> Example of a patch submitted by the From: author::
>>
>>         <changelog>
>>
>>         Co-developed-by: First Co-Author <first@xxxxxxxxxxxxxxxxxxxx>
>>         Signed-off-by: First Co-Author <first@xxxxxxxxxxxxxxxxxxxx>
>>         Co-developed-by: Second Co-Author <second@xxxxxxxxxxxxxxxxxxxx>
>>         Signed-off-by: Second Co-Author <second@xxxxxxxxxxxxxxxxxxxx>
>>         Signed-off-by: From Author <from@xxxxxxxxxxxxxxxxxx>
>>
>> Example of a patch submitted by a Co-developed-by: author::
>>
>>         From: From Author <from@xxxxxxxxxxxxxxxxxx>
>>
>>         <changelog>
>>
>>         Co-developed-by: Random Co-Author <random@xxxxxxxxxxxxxxxxxxxx>
>>         Signed-off-by: Random Co-Author <random@xxxxxxxxxxxxxxxxxxxx>
>>         Signed-off-by: From Author <from@xxxxxxxxxxxxxxxxxx>
>>         Co-developed-by: Submitting Co-Author <sub@xxxxxxxxxxxxxxxxxxxx>
>>         Signed-off-by: Submitting Co-Author <sub@xxxxxxxxxxxxxxxxxxxx>
> 
> I was expecting some reaction from you or Thomas, but since I got a ping
> from Thomas for this not being processed, I'll process it according to
> my assessment of this thread.
> 
> Thanks,
> 
> - Arnaldo
> 
> 

Thanks Arnaldo,

sorry, but I was not aware that you were waiting for feedback from us.
I am fine with your assessment, I actually care more about the patch
being picked...

-- 
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH

Vorsitzender des Aufsichtsrats: Wolfgang Wendt

Geschäftsführung: David Faller

Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294