Re: [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function
From: Jason Xing
Date: Fri May 16 2025 - 01:03:46 EST
On Fri, May 16, 2025 at 12:37 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Thu, May 15, 2025 at 02:16:41PM +0800, Jason Xing wrote:
> > +extern size_t relay_dump(struct rchan *chan, int flags);
>
> Please don't add pointless externs for function prototypes.
Do you mean make it inline in include/linux/relay.h like how
relay_write() works?
Will do that.
>
> > +EXPORT_SYMBOL_GPL(relay_dump);
>
> This export seems unused even with the entire series applied.
My initial thought was to provide a symbol for some kernel modules to use.
Thanks,
Jason