Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic

From: David Howells
Date: Thu Jan 26 2023 - 06:35:14 EST


David Hildenbrand <david@xxxxxxxxxx> wrote:

> > Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> > Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>
> > cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > cc: Jens Axboe <axboe@xxxxxxxxx>
> > cc: Jan Kara <jack@xxxxxxx>
> > cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
> > cc: Logan Gunthorpe <logang@xxxxxxxxxxxx>
> > cc: linux-block@xxxxxxxxxxxxxxx
> > ---
>
> Oh, and I agree with a previous comment that this patch should also hold a
> Signed-off-by from Christoph above your Signed-off-by, if he is mentioned as
> the author via "From:".

I think that was actually in reference to patch 3, but yes - and possibly a
Co-developed-by tag. Christoph?

David