Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic

[David Hildenbrand]

On 25.01.23 22:06, David Howells wrote:
> From: Christoph Hellwig <hch@xxxxxx>
>
> Replace BIO_NO_PAGE_REF with a BIO_PAGE_REFFED flag that has the inverted
> meaning is only set when a page reference has been acquired that needs to
> be released by bio_release_pages().
>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>
> cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> cc: Jens Axboe <axboe@xxxxxxxxx>
> cc: Jan Kara <jack@xxxxxxx>
> cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
> cc: Logan Gunthorpe <logang@xxxxxxxxxxxx>
> cc: linux-block@xxxxxxxxxxxxxxx
> ---

Oh, and I agree with a previous comment that this patch should also hold 
a Signed-off-by from Christoph above your Signed-off-by, if he is 
mentioned as the author via "From:".

I remember stumbling over that in submitting-patches.rst ...

--
Thanks,

David / dhildenb