Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic

From: Christoph Hellwig
Date: Thu Jan 26 2023 - 10:14:32 EST


On Thu, Jan 26, 2023 at 11:34:10AM +0000, David Howells wrote:
> David Hildenbrand <david@xxxxxxxxxx> wrote:
>
> > > Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> > > Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>
> > > cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > > cc: Jens Axboe <axboe@xxxxxxxxx>
> > > cc: Jan Kara <jack@xxxxxxx>
> > > cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
> > > cc: Logan Gunthorpe <logang@xxxxxxxxxxxx>
> > > cc: linux-block@xxxxxxxxxxxxxxx
> > > ---
> >
> > Oh, and I agree with a previous comment that this patch should also hold a
> > Signed-off-by from Christoph above your Signed-off-by, if he is mentioned as
> > the author via "From:".
>
> I think that was actually in reference to patch 3, but yes - and possibly a
> Co-developed-by tag. Christoph?

As I said feel free to add a co-developed by if you want. But more
importantly restore my signoff from here:

http://git.infradead.org/users/hch/misc.git/commitdiff/37ea178d5d95166196112905aa75d85cb0416d49