Re: [PATCH v2 0/5] Some cleanups and improvements for blk-iocost

From: Jens Axboe
Date: Mon Dec 07 2020 - 10:03:11 EST


On 11/26/20 1:16 AM, Baolin Wang wrote:
> Hi,
>
> This patch set did some cleanups and improvements for blk-iocost, and
> no big functional changes. Please help to review. Thanks.
>
> Changes from v1:
> - Add acked-by tag from Tejun.
> - Drop 2 unnecessary patches.
> - Move the related variable declarations inside the block together
> with the code in patch 3.
> - Move the commit_weights() into ioc_check_iocgs().
> - Move more related logics of adjusting base vrate into the
> ioc_adjust_base_vrate().
> - Rename the new functions.
>
> Baolin Wang (5):
> blk-iocost: Fix some typos in comments
> blk-iocost: Remove unnecessary advance declaration
> blk-iocost: Move the usage ratio calculation to the correct place
> blk-iocost: Factor out the active iocgs' state check into a separate
> function
> blk-iocost: Factor out the base vrate change into a separate function
>
> block/blk-iocost.c | 251 +++++++++++++++++++++++++++++------------------------
> 1 file changed, 137 insertions(+), 114 deletions(-)

Applied, thanks.

--
Jens Axboe