Re: [PATCH][next] block/rnbd: fix a null pointer dereference on dev->blk_symlink_name

From: Jinpu Wang
Date: Mon Dec 07 2020 - 10:03:34 EST


On Mon, Dec 7, 2020 at 4:01 PM Jens Axboe <axboe@xxxxxxxxx> wrote:
>
> On 12/7/20 7:54 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > Currently in the case where dev->blk_symlink_name fails to be allocates
> > the error return path attempts to set an end-of-string character to
> > the unallocated dev->blk_symlink_name causing a null pointer dereference
> > error. Fix this by returning with an explicity ENOMEM error (which also
> > is missing in the original code as was not initialized).
>
> Applied, thanks.

Thanks Colin for the fix, and thanks Jens for taking care of this.

Jack Wang