Re: [PATCH v2 0/5] Some cleanups and improvements for blk-iocost

From: Baolin Wang
Date: Mon Dec 07 2020 - 02:20:50 EST


Hi Jens,

Hi,

This patch set did some cleanups and improvements for blk-iocost, and
no big functional changes. Please help to review. Thanks.

Changes from v1:
- Add acked-by tag from Tejun.
- Drop 2 unnecessary patches.
- Move the related variable declarations inside the block together
with the code in patch 3.
- Move the commit_weights() into ioc_check_iocgs().
- Move more related logics of adjusting base vrate into the
ioc_adjust_base_vrate().
- Rename the new functions.

Could you take this patch set if no objection from your side? Thanks.


Baolin Wang (5):
blk-iocost: Fix some typos in comments
blk-iocost: Remove unnecessary advance declaration
blk-iocost: Move the usage ratio calculation to the correct place
blk-iocost: Factor out the active iocgs' state check into a separate
function
blk-iocost: Factor out the base vrate change into a separate function

block/blk-iocost.c | 251 +++++++++++++++++++++++++++++------------------------
1 file changed, 137 insertions(+), 114 deletions(-)