Re: [PATCH] pinctrl: qcom: Don't lock around irq_set_irq_wake()

[Linus Walleij]

On Tue, Jan 21, 2020 at 7:09 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:

> We don't need to hold the local pinctrl lock here to set irq wake on the
> summary irq line. Doing so only leads to lockdep warnings instead of
> protecting us from anything. Remove the locking.
(...)
> Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver")
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Cc: Brian Masney <masneyb@xxxxxxxxxxxxx>
> Cc: Lina Iyer <ilina@xxxxxxxxxxxxxx>
> Cc: Maulik Shah <mkshah@xxxxxxxxxxxxxx>
> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

Fixed the Fixes: tag, added BjÃrn's ACK and applied!

Yours,
Linus Walleij