Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers

From: Marc Gonzalez
Date: Thu Jan 23 2020 - 10:31:31 EST


On 07/01/2020 09:12, Krzysztof Kozlowski wrote:

> Some of the I2C bus drivers can be compile tested to increase build
> coverage. This requires also:
> 1. Adding dependencies on COMMON_CLK for BCM2835 and Meson I2C
> controllers,
> 2. Adding 'if' conditional to 'default y' so they will not get enabled
> by default on all other architectures,
> 3. Limiting few compile test options to supported architectures (which
> provide the readsX()/writesX() primitives).
>
> config I2C_BCM_KONA
> tristate "BCM Kona I2C adapter"
> - depends on ARCH_BCM_MOBILE
> - default y
> + depends on ARCH_BCM_MOBILE || COMPILE_TEST
> + default y if ARCH_BCM_MOBILE

Why not the simpler:
default ARCH_BCM_MOBILE

Regards.