Re: [PATCH] pinctrl: qcom: Don't lock around irq_set_irq_wake()

[Stephen Boyd]

Quoting Bjorn Andersson (2020-01-21 10:35:19)
> On Tue 21 Jan 10:09 PST 2020, Stephen Boyd wrote:
> 
> >   __vfs_write+0x54/0x18c
> >   vfs_write+0xe4/0x1a4
> >   ksys_write+0x7c/0xe4
> >   __arm64_sys_write+0x20/0x2c
> >   el0_svc_common+0xa8/0x160
> >   el0_svc_handler+0x7c/0x98
> >   el0_svc+0x8/0xc
> > 
> > Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver")
> 
> This lock used to protect the wake_irqs bitmap, and although your change
> indicates that the locking was wrong before this point I think the fixes
> should be:
> 
> Fixes: 6aced33f4974 ("pinctrl: msm: drop wake_irqs bitmap")
> 
> 
> Either way, the patch looks good.
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> 

Ok. Thanks for fixing the Fixes tag.