Re: [PATCH 4/8] ARM: dts: aspeed-romulus: Add I2C devices

[Joel Stanley]

On Wed, Oct 4, 2017 at 2:32 PM, Andrew Jeffery <andrew@xxxxxxxx> wrote:
> On Thu, 2017-09-28 at 17:21 +0930, Joel Stanley wrote:
>> Enable the buses that are in use and the devices that are attached.
>> Currently that is just the battery backed RTC.
>>
>> Some of these buses are for hotplugged cards, such as PCIe cards. Others
>> do not yet have upstream drivers, so there are no devices attached.
>>
>> Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 54 ++++++++++++++++++++++++++++
>>  1 file changed, 54 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> index 1190fec1b5d0..f79c1d21c47f 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> @@ -79,3 +79,57 @@
>>       pinctrl-names = "default";
>>       pinctrl-0 = <&pinctrl_rmii1_default>;
>>  };
>> +
>> +&i2c2 {
>> +     status = "okay";
>> +};
>> +
>> +&i2c3 {
>> +     status = "okay";
>> +};
>> +
>> +&i2c4 {
>> +     status = "okay";
>> +};
>> +
>> +&i2c5 {
>> +     status = "okay";
>> +};
>> +
>> +&i2c6 {
>> +     /* PCIe slot 1 (x8) */
>> +     status = "enabled";
>
> This is not okay. Neither are those below.

Hah. Well spotted.

Cheers,

Joel