Re: [PATCH 2/8] ARM: dts: aspeed: Reorder ADC node

From: Andrew Jeffery
Date: Wed Oct 04 2017 - 01:21:45 EST


On Wed, 2017-10-04 at 14:43 +0930, Joel Stanley wrote:
> > > > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ adc: adc@1e6e9000 {
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ compatible = "aspeed,ast2500-adc";
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ reg = <0x1e6e9000 0xb0>;
> >
> > Did you intend to change the size cell value here? It now matches the g4, but
> > there was an explicit comment about the size for some reason in the -hunk
> > below. It's probably worth an explicit call-out if we're going to change it.
>
> Looks ok to me.

Yeah, sorry, was looking in the wrong spot :/

Andrew

Attachment: signature.asc
Description: This is a digitally signed message part