Re: [PATCH 3/5] mfd: tc3589x: reform device tree probing
From: Lee Jones
Date: Tue Jan 21 2014 - 12:15:41 EST
> > This changes the following mechanisms in the TC3589x device tree
> > probing path:
> > - Use the .of_match_table in struct device_driver to match the
> > device in the device tree.
> > - Add matches for the proper compatible strings "toshiba,..."
> > and all sub-variants, just as is done for the .id matches.
> > - Move over all the allocation of platform data etc to the
> > tc3589x_of_probe() function and follow the pattern of passing
> > a platform data pointer back, or an error pointer on error,
> > as found in the STMPE driver.
> > - Match the new (proper) compatible strings for the GPIO and
> > keypad MFD cells.
> > - Use of_device_is_compatible() rather than just !strcmp()
> > to discover which cells to instantiate.
> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Waiting for this patch to go in as well... I can resend the
> entire set of it helps.
If you do so, I'll endeavour to get them sent during -rc1.
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/