Re: [PATCH 3/5] mfd: tc3589x: reform device tree probing

From: Linus Walleij
Date: Tue Jan 21 2014 - 08:37:46 EST

On Tue, Oct 15, 2013 at 11:16 PM, Linus Walleij
<linus.walleij@xxxxxxxxxx> wrote:

> This changes the following mechanisms in the TC3589x device tree
> probing path:
> - Use the .of_match_table in struct device_driver to match the
> device in the device tree.
> - Add matches for the proper compatible strings "toshiba,..."
> and all sub-variants, just as is done for the .id matches.
> - Move over all the allocation of platform data etc to the
> tc3589x_of_probe() function and follow the pattern of passing
> a platform data pointer back, or an error pointer on error,
> as found in the STMPE driver.
> - Match the new (proper) compatible strings for the GPIO and
> keypad MFD cells.
> - Use of_device_is_compatible() rather than just !strcmp()
> to discover which cells to instantiate.
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Waiting for this patch to go in as well... I can resend the
entire set of it helps.

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at