Re: [ibm-acpi-devel] [PATCH] video: backlight: Remove backlightsysfs uevent

From: Matthew Garrett
Date: Sat Nov 23 2013 - 20:03:36 EST


On Sat, Nov 23, 2013 at 10:40:15PM -0200, Henrique de Moraes Holschuh wrote:
> On Fri, 22 Nov 2013, Matthew Garrett wrote:
> > We have userspace that relies on uevents of type
> > BACKLIGHT_UPDATE_HOTKEY. I don't know that we have userspace that relies
> > on uevents of type BACKLIGHT_UPDATE_SYSFS.
>
> Any OSD application would have to rely on both uevent types, or it is broken
> (and to test that, just write a level to sysfs and watch the OSD app fail to
> tell you about the backlight level change...)

Right, OSDs are supposed to respond to keypresses, not arbitrary changes
of backlight. If the user's just echoed 8 into brightness, they know
they set the brightness to 8 - they don't need an OSD to tell them that.
BACKLIGHT_UPDATE_HOTKEY is when the firmware itself has changed the
brightness in response to a keypress, and so reporting the keypress
would result in additional backlight changes.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/