Re: [ibm-acpi-devel] [PATCH] video: backlight: Remove backlightsysfs uevent

[Henrique de Moraes Holschuh]

On Fri, 22 Nov 2013, Matthew Garrett wrote:
> On Fri, Nov 22, 2013 at 09:36:01AM -0200, Henrique de Moraes Holschuh wrote:
> > On Thu, 21 Nov 2013, Matthew Garrett wrote:
> > > The uevent support was initially added to handle systems where pressing 
> > > a hotkey generates an event (good) but the firmware automatically 
> > > changes the brightness (bad). I have absolutely no idea why I added 
> > > BACKLIGHT_UPDATE_SYSFS - BACKLIGHT_UPDATE_HOTKEY solves the problem I 
> > > was trying to solve. I'm not aware of any userspace that relies on 
> > > BACKLIGHT_UPDATE_SYSFS.
> > 
> > Well, either we have userspace that rely on the uevents, or we don't. 
> 
> We have userspace that relies on uevents of type 
> BACKLIGHT_UPDATE_HOTKEY. I don't know that we have userspace that relies 
> on uevents of type BACKLIGHT_UPDATE_SYSFS.

Any OSD application would have to rely on both uevent types, or it is broken
(and to test that, just write a level to sysfs and watch the OSD app fail to
tell you about the backlight level change...)

I don't know about other types of applications, though.  What other type of
applications pay attention to backlight uevents?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/