Re: [PATCH] sysfs: handle duplicate removal attempts in sysfs_remove_group()

[Rafael J. Wysocki]

On Sunday, November 24, 2013 12:36:03 AM Rafael J. Wysocki wrote:
> On Saturday, November 23, 2013 03:07:01 PM Greg Kroah-Hartman wrote:
> > On Sun, Nov 24, 2013 at 12:12:59AM +0100, Rafael J. Wysocki wrote:
> > > On Saturday, November 23, 2013 02:53:58 PM Greg Kroah-Hartman wrote:

[...]

> > > > 
> > > > I can revert Mika's patch, as it would be good to catch these kinds of
> > > > errors.
> > > 
> > > Then we'll need to untangle the SATA/SCSI mess triggered by Bjorn in
> > > https://bugzilla.kernel.org/show_bug.cgi?id=65281. ;-)
> > 
> > I have no objection to fixing that, the scsi sysfs handling is "odd" to
> > say the least...
> > 
> > If someone can unwind it, that would be great to see happen...
> 
> Well, if I'm bored to death during the xmas holidays, I may look into that.

In fact, I'm not exactly sure why ata_port_detach() calls ata_tport_delete()
before scsi_remove_host()?  Is there any particular reason?  Because that
doesn't seem to be exactly right ...

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/