Re: [PATCH v2] iio: ti_am335x_adc: Take touchscreen steps into accountfor conversion timeout

[Arun Joseph]

On Sunday 22 September 2013 11:21 PM, Matthias Kaehlcke wrote:
> Hi,
>
> El Sat, Sep 21, 2013 at 01:25:42PM +0100 Jonathan Cameron ha dit:
>
> > On 09/16/13 22:17, Matthias Kaehlcke wrote:
> > > The calculation of the old conversion timeout value was based on the number of
> > > steps used by this driver. This doesn't take into account that other steps
> > > can be used by the touchscreen driver. Select the timeout value based on the
> > > steps used by both drivers
> > >
> > > Signed-off-by: Matthias Kaehlcke <matthias@xxxxxxxxxxxx>
> > Looks fine to me but I'd like an Ack from someone more familiar with the device
> > if possible.
> Arun, do you feel entitled to Ack or can you suggest someone from TI
> who is?
Adding Sekhar Nori
> > Also, I'm assuming this is a fix we want to push out asap but that isn't
> > clear in your patch title.  Perhaps something like:
> >
> > iio: ti_am335x_adc: Fix conversion timeout to allow for touch screen steps.
> > ?
> it's not as critical as it seems as in practice the timeout has the
> granularity of a jiffy. If you prefer I still can resend the patch
> with the subject you suggest
>
> best regards

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/