Re: [PATCH v1 5/6] bitops: Introduce BIT_ULL

[Srinivas Pandruvada]

On 09/19/2013 09:48 AM, Borislav Petkov wrote:
> On Thu, Sep 19, 2013 at 09:00:34AM -0700, Srinivas Pandruvada wrote:
> > Adding BIT(x) equivalent for unsigned long long type, BIT_ULL(x).
> >
> > Suggested-by: Joe Perches <joe@xxxxxxxxxxx>
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > Signed-off-by: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
> > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > ---
> >   include/linux/bitops.h | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/bitops.h b/include/linux/bitops.h
> > index a3b6b82..34e9e94 100644
> > --- a/include/linux/bitops.h
> > +++ b/include/linux/bitops.h
> > @@ -4,6 +4,7 @@
> >   
> >   #ifdef	__KERNEL__
> >   #define BIT(nr)			(1UL << (nr))
> > +#define BIT_ULL(nr)		(1ULL << (nr))
> We already have BIT_64 for that.
The current definition for BIT_64 is in arch/x86/include/asm/bitops.h. I 
feel it should be applicable for all architectures and move to some 
common file.

Thanks,
Srinivas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/