Re: [PATCH 1/9] migrate: make core migration code aware of hugepage

[Naoya Horiguchi]

On Tue, Sep 10, 2013 at 02:51:30PM +0100, Mel Gorman wrote:
> On Fri, Aug 09, 2013 at 01:21:34AM -0400, Naoya Horiguchi wrote:
> > Before enabling each user of page migration to support hugepage,
> > this patch enables the list of pages for migration to link not only
> > LRU pages, but also hugepages. As a result, putback_movable_pages()
> > and migrate_pages() can handle both of LRU pages and hugepages.
> > 
> 
> LRU pages and *allocated* hugepages.

Right.

> On its own the patch looks ok but it's not obvious at this point what
> happens for pages that are on the hugetlbfs pool lists but not allocated
> by any process.

OK. I'll add comments about clarifying that. Now I'm preparing the next
patchset for migration of 1GB hugepages, so it's done in that series.

> They will fail to isolate because of the
> get_page_unless_zero() check. Maybe it's handled by a later patch.

The callers which determine the target pages with virtual address (like
mbind, migrate_pages) don't try to migrate hugepages in the hugetlbfs
pool. And the other callers which determine targets with physical address
(like memory hotplug and soft offline) have their own check not to migrate
free hugepages.

Thanks,
Naoya Horiguchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/