Re: [PATCH 1/9] migrate: make core migration code aware of hugepage

From: Mel Gorman
Date: Tue Sep 10 2013 - 09:51:42 EST


On Fri, Aug 09, 2013 at 01:21:34AM -0400, Naoya Horiguchi wrote:
> Before enabling each user of page migration to support hugepage,
> this patch enables the list of pages for migration to link not only
> LRU pages, but also hugepages. As a result, putback_movable_pages()
> and migrate_pages() can handle both of LRU pages and hugepages.
>

LRU pages and *allocated* hugepages.

On its own the patch looks ok but it's not obvious at this point what
happens for pages that are on the hugetlbfs pool lists but not allocated
by any process. They will fail to isolate because of the
get_page_unless_zero() check. Maybe it's handled by a later patch.

--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/