Re: [PATCH] workqueue: remove redundanttimer_stats_timer_set_start_info() call

From: Tejun Heo
Date: Tue Sep 10 2013 - 09:45:41 EST


On Tue, Sep 10, 2013 at 02:35:27PM +0800, Libin wrote:
> From: Li Bin <huawei.libin@xxxxxxxxxx>
>
> There is a redundant call for timer_stats_timer_set_start_info(),
> because it is the responsibility of the 'timer add' function:
>
> add_timer_on()
> |- timer_stats_timer_set_start_info()
>
> add_timer()
> |- mod_timer()
> |- __mod_timer()
> |- timer_stats_timer_set_start_info()
>
> So the calling here is redundant, remove it.

I think it's intentional to record the caller's address so that timers
from delayed_work items can be distinguished.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/