Re: [PATCH] usb: Move definition of USB_EHCI_BIG_ENDIAN_MMIO outside of the ifs.

[Alan Stern]

On Fri, 9 Aug 2013, David Daney wrote:

> From: David Daney <david.daney@xxxxxxxxxx>
> 
> When CONFIG_USB_SUPPORT is not selected we get things like:
> 
> scripts/kconfig/mconf Kconfig
> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
> 
> It is much cleaner to make the various system Kconfigs select
> USB_EHCI_BIG_ENDIAN_MMIO rather than move the system config
> information into USB's Kconfig, but the warnings are annoying.
> 
> Eliminate the warning by moving the definition of
> USB_EHCI_BIG_ENDIAN_MMIO outside of all the Kconfig if statements.

This is a good thing to do, but you should also move 
USB_EHCI_BIG_ENDIAN_DESC.

And while you're at it, might as well move USB_OHCI_BIG_ENDIAN_DESC, 
USB_OHCI_BIG_ENDIAN_MMIO, and USB_OHCI_LITTLE_ENDIAN outside their "if" 
blocks.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/