Re: [PATCH] drivers: Select dependencies for the VIRTUALIZATION symbol

[Markos Chandras]

On 9 June 2013 00:40, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> On 06/07/13 04:23, Markos Chandras wrote:
>> The VIRTUALIZATION symbol depends on HAVE_KVM but CONFIG_REMOTEPROC
>> and CONFIG_RPMSG do not select HAVE_KVM leading to the following
>> warning and build problems later on:
>>
>> warning: (REMOTEPROC && RPMSG) selects VIRTUALIZATION which has unmet
>> direct dependencies (HAVE_KVM)
>> warning: (REMOTEPROC && RPMSG) selects VIRTUALIZATION which has unmet
>> direct dependencies (HAVE_KVM)
>>
>> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
>> Cc: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
>
> This seems odd.  Usually architectures declare that they HAVE_xyz
> and then drivers etc. can use that symbol to do (or not do) something.
>
> See Documentation/kbuild/kconfig-language.txt and search for /HAVE_/.
>
>> ---
>>  drivers/remoteproc/Kconfig | 1 +
>>  drivers/rpmsg/Kconfig      | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
>> index d4d377c..79648ca 100644
>> --- a/drivers/remoteproc/Kconfig
>> +++ b/drivers/remoteproc/Kconfig
>> @@ -6,6 +6,7 @@ config REMOTEPROC
>>       depends on HAS_DMA
>>       select CRC32
>>       select FW_LOADER
>> +     select HAVE_KVM
>>       select VIRTIO
>>       select VIRTUALIZATION
>>
>> diff --git a/drivers/rpmsg/Kconfig b/drivers/rpmsg/Kconfig
>> index 69a2193..3f0bd0f 100644
>> --- a/drivers/rpmsg/Kconfig
>> +++ b/drivers/rpmsg/Kconfig
>> @@ -3,6 +3,7 @@ menu "Rpmsg drivers"
>>  # RPMSG always gets selected by whoever wants it
>>  config RPMSG
>>       tristate
>> +     select HAVE_KVM
>>       select VIRTIO
>>       select VIRTUALIZATION
>>
>>
>
>
> --
> ~Randy
> --

Hi Randy,

Thanks for the review. Ok makes sense now. I will prepare a new patch.

--
Regards,
Markos Chandras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/