Re: [PATCH 2/5] lockdep: check that no locks held at freeze time
From: Ingo Molnar
Date: Fri Feb 15 2013 - 06:16:44 EST
* Mandeep Singh Baines <msb@xxxxxxxxxxxx> wrote:
> --- a/kernel/lockdep.c
> +++ b/kernel/lockdep.c
> @@ -4091,10 +4091,10 @@ static void print_held_locks_bug(struct task_struct *curr)
> return;
>
> printk("\n");
> - printk("=====================================\n");
> - printk("[ BUG: lock held at task exit time! ]\n");
> + printk("=======================================\n");
> + printk("[ BUG: lock held at exit/freeze time! ]\n");
Looks good, but to make it more apparent which case triggers,
please pass in a 'msg' string that gets printed - and the msg is
either "exit" or "freeze", depending on from where it's called.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/