[PATCH] dmaengine: ste_dma40: do not remove descriptors for cyclic transfers

From: Fabio Baltieri
Date: Thu Feb 14 2013 - 04:03:32 EST

Fix dma_tc_handle() to call d40_desc_remove() and d40_desc_done() only
for non-cyclic transfers, as this was breaking ux500_pcm since
introduced in:

d49278e dmaengine: dma40: Add support to split up large elements

Reported-by: Shreshtha Kumar Sahu <shreshthakumar.sahu@xxxxxxxxxxxxxx>
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Signed-off-by: Fabio Baltieri <fabio.baltieri@xxxxxxxxxx>

Hello Vinod,

the bug fixed by this patch was around for some time, but the affected
driver (ux500_pcm) will be enabled in next release cycle for other
reasons so this patch can safely go on -next.

Would you take it your tree?


drivers/dma/ste_dma40.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index ad860a2..1734fee 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -1570,10 +1570,10 @@ static void dma_tc_handle(struct d40_chan *d40c)
d40c->busy = false;
- }

- d40_desc_remove(d40d);
- d40_desc_done(d40c, d40d);
+ d40_desc_remove(d40d);
+ d40_desc_done(d40c, d40d);
+ }


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/