Re: [PATCH v2 0/1] OMAP4: DSS: Add panel for Blaze Tablet boards

From: Tomi Valkeinen
Date: Wed Feb 13 2013 - 03:18:56 EST


On 2013-02-08 17:43, Ruslan Bilovol wrote:
> Hi,
> This patch adds support for TC358765 DSI-to-LVDS transmitter
> from Toshiba, that is used in OMAP4 Blaze Tablet development
> platform. It was originally developed a long time ago and
> was used internally survived few kernel migrations.
> Different people worked in this driver during last two
> years changing its sources to what each new version of
> kernel expects.
> Current version is ported from internal kernel v3.4 to 3.8.0-rc6
> Tested basic functioning under busybox.

Thanks for updating the driver to a recent kernel.

I didn't review the patch line by line, but with a brief look it looks
fine. However, I'm not quite sure what to do with this patch.

The problem is that the driver is a combined driver for the TC358765
chip and the panel on Blaze Tablet, and we are very much trying to fix
that design issue so that the drivers for the chip and panel could be
separate, as they should.

So I fear that if I now accept the patch, it'll increase my burden of
managing the display drivers during this design rework. Furthermore, to
my knowledge the Blaze Tablet is quite a rare board, and it's not even
supported in the mainline kernel, so this driver wouldn't be usable by

So if I'm right about the blaze tablet status, I'm inclined to say that
I think this should be still kept out of tree.


Attachment: signature.asc
Description: OpenPGP digital signature