Re: [PATCH linux-next] befs: befs_fill_super(): remove unreachablecode

From: Tim Gardner
Date: Tue Feb 12 2013 - 13:07:54 EST


On 02/12/2013 10:46 AM, Eric W. Biederman wrote:
> Tim Gardner <tim.gardner@xxxxxxxxxxxxx> writes:
>
>> befs_sb->num_blocks is of base type u64 which is the same as sector_t.
>> Therefore, num_blocks can never be larger then the maximum
>> value of sector_t.
>
> The analysys is wrong. On 32bit with CONFIG_LBAF unset sector_t is an
> unsigned long aka a u32, while befs_off_t is always a u64.
>
> Nacked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Dang - you're right.

--
Tim Gardner tim.gardner@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/