Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user()warnings

From: H. Peter Anvin
Date: Mon Feb 11 2013 - 23:52:04 EST

On 02/11/2013 08:47 PM, Linus Torvalds wrote:
On Mon, Feb 11, 2013 at 8:42 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

But I don't see anything fundamentally wrong with it. Certainly it
looks much better than the disgusting and warning-prone

unsigned long long __val_gu8


Oh. I just realized. That was your _baseline_ in the comparisons, wasn't it?

Can you please make the baseline be the current mainline git version
of <asm/uaccess.h>, not the first "unsigned long long __val_gu8"
version of the 64-bit get_user()?

Because we should compare against the straightforward code, not the
one that could have messed things up already..

No, the baseline was x86/mm before *any* of the 64-bit get_user() stuff were applied.

Very small differences can often be slight differences in strings (which end up in .rodata and thus count as text as far as size is concerned ... things like pathnames and dates.) I am unclear about why the i386-pae build case stood out like that.


H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at