Re: query about create_mnt_ns

From: Al Viro
Date: Mon Feb 11 2013 - 09:10:34 EST

On Mon, Feb 11, 2013 at 05:44:29PM +0530, Rajat Sharma wrote:
> Hi,
> I was looking at implementation of init_mount_tree() function and
> found a discrepancy in list manipulation of mnt_namsespace and
> vfsmount across kernel version 2.6.30. Up till kernel version
> 2.6.30.x, vfsmount structure was added to the list headed by
> mnt_namespace structure just allocated:
> list_add(&mnt->mnt_list, &ns->list);
> Beyond that with the introduction of function create_mnt_ns(), it does
> reverse of previous behavior:
> list_add(&new_ns->list, &mnt->mnt_list);
> i.e. it is adding new mnt_namespace to the vfsmount list. Is this the
> expected behavior? i.e. do we want to maintain list of namespaces per
> mount? Please let me know if I am missing something here.

The fact that if A and B are both empty, list_add(A, B) and list_add(B, A)
will do exactly the same thing ;-)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at