Re: [PATCH RFC] regulator: suppress printk if there is no real info

[Uwe Kleine-König]

On Tue, Aug 07, 2012 at 07:10:22PM +0100, Mark Brown wrote:
> On Mon, Aug 06, 2012 at 11:18:40AM +0200, Uwe Kleine-König wrote:
> 
> > probably this really only applies to the dummy regulator. If not it
> > might be more sensible to do:
> 
> > 	if (!buf[0])
> > 		buf = "no parameters";
> 
> Yeah, having the log message for other regulators is helpful since
> things often go boom after you mess with power but not so useful for
> dummy.
That's a +1 for which approach?
 
> > or similar. Other than that I wonder if setting the devicename from
> > "dummy" to say "regulator-dummy" would be an improvement, too.
> 
> That'd work too.
I'd like to combine it with one of the two suggested above.
If you answer my question I can follow up with a patch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/