Re: [PATCH RFC] regulator: suppress printk if there is no real info

From: Mark Brown
Date: Tue Aug 07 2012 - 14:10:20 EST


On Mon, Aug 06, 2012 at 11:18:40AM +0200, Uwe Kleine-König wrote:

> probably this really only applies to the dummy regulator. If not it
> might be more sensible to do:

> if (!buf[0])
> buf = "no parameters";

Yeah, having the log message for other regulators is helpful since
things often go boom after you mess with power but not so useful for
dummy.

> or similar. Other than that I wonder if setting the devicename from
> "dummy" to say "regulator-dummy" would be an improvement, too.

That'd work too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/