Re: [PATCH 08/18] perf evlist: Introduce perf_evlist__parse_sample

From: Stephane Eranian
Date: Fri Aug 03 2012 - 13:28:31 EST


On Fri, Aug 3, 2012 at 5:24 PM, David Ahern <dsahern@xxxxxxxxx> wrote:
> On 8/3/12 8:01 AM, Arnaldo Carvalho de Melo wrote:
>>
>> From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>>
>> That is a more compact form of perf_session__parse_sample and to support
>> multiple evlists per perf_session is the way to go anyway.
>
>
> So then all events in an evlist will have the same sample type? If you want
> different sample types (at some point in the future) you will have to create
> separate evlists?
>
Yes, you do want separate sample_type, otherwise you may be wasting a lot
of buffer space and thus disk space for data you don't want. This is especially
true once you start using the branch stack feature. But for that the
kernel buffer
format has to be extended. I have a patch that does that. Just haven't
had the time
to finish the perf support for it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/