Re: [PATCH] [Trivial] qib: fix an incorrect message

From: Joe Perches
Date: Thu Jul 19 2012 - 14:03:10 EST

On Thu, 2012-07-19 at 13:34 -0600, Betty Dall wrote:
> There is a cut and paste typo in the function qib_pci_slot_reset() where
> it prints that the "link_reset" function is called rather than the
> "slot_reset" function. This makes the message misleading.

Hi Betty.

> diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c
> @@ -725,7 +725,7 @@ qib_pci_mmio_enabled(struct pci_dev *pdev)
> static pci_ers_result_t
> qib_pci_slot_reset(struct pci_dev *pdev)
> {
> - qib_devinfo(pdev, "QIB link_reset function called, ignored\n");
> + qib_devinfo(pdev, "QIB slot_reset function called, ignored\n");

These sorts of typos can be avoided by using "%s: ", __func__

qib_devinfo(pdev, "QIB %s: called, ignored\n", __func__);

cheers, Joe

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at