Re: [PATCH RFC V2 3/6] time: keep track of the pending utc/tai threshold

[John Stultz]

On 05/23/2012 12:17 PM, Richard Cochran wrote:
> On Wed, May 23, 2012 at 09:50:13AM -0700, John Stultz wrote:
> > On 05/23/2012 01:29 AM, Richard Cochran wrote:
> > > Okay, if you want it that way, then you will have to add the other
> > > cases. For example:
> > >
> > > 	switch (code) {
> > > 	case INS:
> > > 		if (U == epoch) {
> > > 			U--;
> > > 			T++;
> > > 			code = OOP;
> > > 		}
> > > 		break;
> > > 	case OOP:
> > > 		if (U == epoch) {
> > epoch + 1 here, right?
> No, I really mean epoch (not the leap second value, but the value when
> the new TAI offset comes into effect).
>
> > > 			code = WAIT;
> > > 		}
> > > 		break;
> > > 	case DEL:
> > > 		if (U == epoch - 1) {
> > > 			U++;
> > > 			T--;
> > > 			code = WAIT;
> > > 		}
> > > 		break;
> > > 	default:
> > > 		break;
> > > 	}
> > > 	return (U, code, T);
> > >
> > > This is beginning to look a lot like the code in my patch. However,
> > > your approach is somewhat simpler, because it assumes the tick will
> > > never miss a second overflow.
> > I'm a little unclear on the above, because it looks like you're
> > modifying the state from the reader.
> Sorry about that. Here is a more exact pseudo code:
>
> 	switch (time_state) {
> 	case INS:
> 		if (U == epoch) {
> 			U--;
> 			T++;
> 			result_code = OOP;
> 		}
> 		break;
> 	case OOP:
> 		if (U == epoch) {
> 			result_code = WAIT;
> 		}
> 		break;
> 	case DEL:
> 		if (U == epoch - 1) {
> 			U++;
> 			T--;
> 			result_code = WAIT;
> 		}
> 		break;
> 	default:
> 		break;
> 	}
> 	return (U, result_code, T);

Again, my issue here is that you're modifying state from the reader. Why 
not leave that to the tick?

> > I still don't think it matters. If we know the when next leap second
> > is supposed to be, if the time_state is INS, then we can still
> > handle things without extra state.
> >
> > if (unlikely(CODE == INS&&    U == next_leap))
> > 	return (U-1, OOP, T+1);
> >
> > if (unlikely(CODE == INS&&    U == next_leap + 1))
> > 	return (U-1, WAIT, T+1);
> And what if (U>  next_leap + 1)?
>
> In that case, you must also return WAIT. Are you going to add a test
> for every second beyond 'next_leap'? I don't think so.
You're quite correct, sorry for the omission there.

if (unlikely((CODE == INS || CODE== OOP)&&    U>= next_leap + 1))
	return (U-1, WAIT, T+1);


> > if (unlikely(CODE == DEL&&    U == next_leap - 1))
> > 	return (U+1, WAIT, T-1);
> >
> >
> > So even if we somehow sleep for two seconds over the leap second,
> > and then an application hits the read critical section before the
> > timer interrupt comes in the update the state, we can still provide
> > correct state transition in the reader.
> No, I think what you wrote above is not correct.
So what's wrong with the corrected line above?

> > Thus the only additional state you might need over what we already
> > have is the next_leap value.
> Again, you will need two things.
>
> 1. the epoch threshold value (not the leap second value)
So I've avoided the term epoch just to try not to confuse things with 
the unix epoch, that's why I've used next_leap, etc.
Even so, I'm not sure you've made clear the subtlety of the difference.


> 2. whether the new epoch has been applied yet, or not
I believe the internal time_state (along with the next leap second) 
already provides this.

From the reader's perspective:

Not applied:		(INS&&  U<  leap):		return (INS, U)
Applied:		(INS&&   U == leap):		return (OOP, U-1)
Finished applied:	((INS||OOP)&&  U>= (leap+1)):	return (WAIT,U-1)
Delete:			(DEL&&  U>= (leap-1)):		return (WAIT,U+1)


Again, no state change is done by the reader, so we don't have to keep 
track of application state or not.
Then when the tick comes in, it will move the state machine appropriately.

Sorry working this out is so difficult. If we don't come to consensus 
soon, I'll try to find some time to implement what I'm suggesting so you 
aren't up against my unclear hand-waving. :)

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/