Re: [PATCH] Add I2C driver for Summit Microelectronics SMB347Battery Charger.

From: Mark Brown
Date: Mon Feb 06 2012 - 11:35:44 EST

On Mon, Feb 06, 2012 at 04:24:09PM +0000, Alan Cox wrote:
> Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> > There's quite a lot of read/modify/write cycles and...

> True but they are basically all in the setup side of things so I'm not
> sure the complexity is justified or appropriate ?

I'm not sure what complexity you mean? If the interface is too
difficult to use we should fix that but I didn't notice anything in the
driver which should be more than a straight substitution (or deletion of
code in the case of the debugfs file).

Attachment: signature.asc
Description: Digital signature