Re: [PATCH] Add I2C driver for Summit Microelectronics SMB347Battery Charger.
From: Alan Cox
Date: Mon Feb 06 2012 - 12:04:02 EST
On Mon, 6 Feb 2012 16:35:45 +0000
Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Feb 06, 2012 at 04:24:09PM +0000, Alan Cox wrote:
> > Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > > There's quite a lot of read/modify/write cycles and...
> > True but they are basically all in the setup side of things so I'm not
> > sure the complexity is justified or appropriate ?
> I'm not sure what complexity you mean? If the interface is too
> difficult to use we should fix that but I didn't notice anything in the
> driver which should be more than a straight substitution (or deletion of
> code in the case of the debugfs file).
The API seems fine to me but you've then got to implement the
writeable/readable/volatile reg callbacks and figure out what is cachable
for the chip and specify it.
Seems like overkill for a chip you poke asynchronously during boot and
then basically let it mind its own business.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/