Re: [PATCH] uniform cdrom: fix mutex unlocking in/proc/sys/dev/cdrom/info file

From: Davidlohr Bueso
Date: Tue Jun 15 2010 - 14:41:52 EST

On Mon, 2010-06-14 at 12:34 -0700, Andrew Morton wrote:
> On Wed, 09 Jun 2010 12:56:50 -0400
> Davidlohr Bueso <dave.bueso@xxxxxxxxx> wrote:
> > If the last if condition passes the cdrom_mutex mutex will not be unlocked.
> > This patch fixes this and also removes the unnecessary doit label that was only invoked by the done label.
> >
> Confused. There is no way in which cdrom_sysctl_info() can forget to
> unlock cdrom_mutex.

Ok, I had misread the code then, one of the reasons I don't like goto
labels, but that's a different story.

Regarding cdrom_sysctl_info(), I have noticed in several netbooks
looked in other machines with no cdrom drive) that the
/proc/sys/dev/cdrom/info file shows no values for the listed entries,

CD-ROM information, Id: cdrom.c 3.20 2003/12/17

drive name:
drive speed:
drive # of slots:
Can close tray:
Can open tray:

Now, is this expected behavior? If not, should it be changed to
more descriptive? Perhaps it would affect user space applications that
the file?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at