Re: [PATCH] uniform cdrom: fix mutex unlocking in/proc/sys/dev/cdrom/info file

From: Andrew Morton
Date: Mon Jun 14 2010 - 15:34:30 EST


On Wed, 09 Jun 2010 12:56:50 -0400
Davidlohr Bueso <dave.bueso@xxxxxxxxx> wrote:

> If the last if condition passes the cdrom_mutex mutex will not be unlocked.
> This patch fixes this and also removes the unnecessary doit label that was only invoked by the done label.
>

Confused. There is no way in which cdrom_sysctl_info() can forget to
unlock cdrom_mutex.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/