Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

[Justin P. Mattock]

On 06/14/2010 01:48 PM, Nick Bowler wrote:
> On 13:26 Mon 14 Jun     , Justin P. Mattock wrote:
> > @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key,	/* Key to s
> >
> >   	pathrelse(search_path);
> >
> > -	right_neighbor_of_leaf_node = 0;
> > -
> > +	
>
> This hunk introduces whitespace on the empty line, which is not cool.

I can resend!!(biggest problem is working
through these warnings)

> >   	/* With each iteration of this loop we search through the items in the
> >   	   current node, and calculate the next current node(next path element)
> >   	   for the next iteration of this loop.. */
> > @@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key,	/* Key to s
> >   			   starting from the root. */
> >   			block_number = SB_ROOT_BLOCK(sb);
> >   			expected_level = -1;
> > -			right_neighbor_of_leaf_node = 0;
> > -
> > +			
>
> Here, too.
>
> Most of the patches in this series have similar issues.

main thing now(for me atleast)is,
is this actual dead code or what?
if not then something else needs to
be done, if yes then I guess I can
resend this, with out the whitespace
issue.

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/