Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

From: Nick Bowler
Date: Mon Jun 14 2010 - 16:48:17 EST


On 13:26 Mon 14 Jun , Justin P. Mattock wrote:
> @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s
>
> pathrelse(search_path);
>
> - right_neighbor_of_leaf_node = 0;
> -
> +

This hunk introduces whitespace on the empty line, which is not cool.

> /* With each iteration of this loop we search through the items in the
> current node, and calculate the next current node(next path element)
> for the next iteration of this loop.. */
> @@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s
> starting from the root. */
> block_number = SB_ROOT_BLOCK(sb);
> expected_level = -1;
> - right_neighbor_of_leaf_node = 0;
> -
> +

Here, too.

Most of the patches in this series have similar issues.

--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/