Re: [PATCH] Staging: vt6656: fix brace coding style issue in80211mgr.c This is a patch to the 80211mgr.c file that fixes up a bracewarning found by the checkpatch.pl tool Signed-off-by: Timofey Trofimov<tumoxep@gmail.com>

From: Charles Clément
Date: Sat May 22 2010 - 13:37:53 EST


Hello Timofey,

I think the message you send should have the Signed-off-by in the body,
as well as the long description of the patch.

On Sat, May 22, 2010 at 08:42:54PM +0400, Timofey Trofimov wrote:
> ---
> drivers/staging/vt6656/80211mgr.c | 514 ++++++++++++++++++-------------------
> 1 files changed, 251 insertions(+), 263 deletions(-)
>
> diff --git a/drivers/staging/vt6656/80211mgr.c b/drivers/staging/vt6656/80211mgr.c
> index f24dc55..7236019 100644
> --- a/drivers/staging/vt6656/80211mgr.c
> +++ b/drivers/staging/vt6656/80211mgr.c
> @@ -67,8 +67,8 @@
>
> /*--------------------- Static Variables --------------------------*/
>
> -static int msglevel =MSG_LEVEL_INFO;
> -//static int msglevel =MSG_LEVEL_DEBUG;
> +static int msglevel = MSG_LEVEL_INFO;
> +/*static int msglevel =MSG_LEVEL_DEBUG;*/
> /*--------------------- Static Functions --------------------------*/

Here, even if the code is commented you could add the extra space, in
case the code is uncommented later.

Charles.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/